drop support for python 3.8 (#28)

pallets-eco · Jun 16, 2024 · 693e517 · 693e517
2 parents 8b89814 + 5eb75c7
commit 693e517
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 53 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python: ['3.12', '3.11', '3.10', '3.9', '3.8']
+        python: ['3.12', '3.11', '3.10', '3.9']
     steps:
       - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
       - uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0

diff --git a/CHANGES.md b/CHANGES.md
@@ -2,6 +2,7 @@
 
 Unreleased
 
+- Drop support for Python 3.8.
 - Support Flask-SQLAlchemy-Lite and plain SQLAlchemy, in addition to
   Flask-SQLAlchemy. {pr}`26`
 - Support multiple databases, and multiple metadata per database. {pr}`26`

diff --git a/pyproject.toml b/pyproject.toml
@@ -16,7 +16,7 @@ classifiers = [
     "Topic :: Database",
     "Typing :: Typed",
 ]
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 dependencies = [
     "alembic>=1.13",
     "flask>=3.0",
@@ -47,14 +47,14 @@ source = ["flask_alembic", "tests"]
 source = ["src", "*/site-packages"]
 
 [tool.mypy]
-python_version = "3.8"
+python_version = "3.9"
 files = ["src/flask_alembic", "tests"]
 show_error_codes = true
 pretty = true
 strict = true
 
 [tool.pyright]
-pythonVersion = "3.8"
+pythonVersion = "3.9"
 include = ["src/flask_alembic", "tests"]
 
 [tool.ruff]

diff --git a/requirements/tests-3.8.in b/requirements/tests-3.8.in
diff --git a/requirements/tests-3.8.txt b/requirements/tests-3.8.txt
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -7,15 +7,15 @@
 import pytest
 from flask import Flask
 from flask.ctx import AppContext
-from flask_sqlalchemy import SQLAlchemy
+from flask_sqlalchemy_lite import SQLAlchemy
 
 from flask_alembic import Alembic
 
 
 @pytest.fixture
 def app(request: pytest.FixtureRequest, tmp_path: Path) -> Flask:
     app = Flask(request.module.__name__, root_path=os.fspath(tmp_path))
-    app.config["SQLALCHEMY_BINDS"] = {
+    app.config["SQLALCHEMY_ENGINES"] = {
         "default": "sqlite://",
         "other": "sqlite://",
     }

diff --git a/tests/test_fsa_lite.py b/tests/test_fsa_lite.py
@@ -5,16 +5,12 @@
 
 import pytest
 from flask import Flask
+from flask_sqlalchemy_lite import SQLAlchemy
 from sqlalchemy import create_engine
 from sqlalchemy.orm import DeclarativeBase
 
 from flask_alembic import Alembic
 
-try:
-    from flask_sqlalchemy_lite import SQLAlchemy
-except ImportError:
-    pytest.skip("flask_sqlalchemy_lite not available", allow_module_level=True)
-
 
 @pytest.fixture
 def app(app: Flask) -> Flask:

diff --git a/tox.ini b/tox.ini
@@ -1,6 +1,6 @@
 [tox]
 envlist =
-    py3{12,11,10,9,8}
+    py3{12,11,10,9}
     style
     typing
     docs
@@ -14,9 +14,6 @@ use_frozen_constraints = true
 deps = -r requirements/tests.txt
 commands = pytest -v --tb=short --basetemp={envtmpdir} {posargs}
 
-[testenv:py38,py3.8]
-deps = -r requirements/tests-3.8.txt
-
 [testenv:style]
 deps = pre-commit
 skip_install = true