ENH: Make print_thing respect display.precision for Real numbers #60613
+35
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Dec 30, 2024
| escape_chars = list(escape_chars.keys()) | ||
| else: | ||
| escape_chars = escape_chars or () | ||
|
|
||
| result = str(thing) | ||
| # Real instance kontrolü ve precision uygulaması | ||
| if isinstance(thing, Real) and not isinstance(thing, int): |
There was a problem hiding this comment.
Can you use is_float from padnas.core.dtypes.inference
| escape_chars = list(escape_chars.keys()) | ||
| else: | ||
| escape_chars = escape_chars or () | ||
|
|
||
| result = str(thing) | ||
| # Real instance kontrolü ve precision uygulaması |
There was a problem hiding this comment.
This comment repeats the code verbatim and can be removed. Also, can you make any comments in English.
| import pytest | ||
|
|
||
| from pandas._config.config import option_context # option_context |
| @@ -155,6 +158,13 @@ def test_east_asian_len(self): | |||
| assert adj.len("パンダpanda") == 11 | |||
| assert adj.len("ﾊﾟﾝﾀﾞpanda") == 10 | |||
|
|
|||
| def test_pprint_thing_real_precision(self): | |||
There was a problem hiding this comment.
Can you move to TestPPrintThing above
| @@ -155,6 +158,13 @@ def test_east_asian_len(self): | |||
| assert adj.len("パンダpanda") == 11 | |||
| assert adj.len("ﾊﾟﾝﾀﾞpanda") == 10 | |||
|
|
|||
| def test_pprint_thing_real_precision(self): | |||
| with option_context('display.precision', 3): | |||
| assert pprint_thing(3.14159265359) == "3.142" | |||
There was a problem hiding this comment.
Use printing.pprint_thing instead, as the other tests here do
rhshadrach
added
Output-Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes ENH: How about let pprint_thing print Real instance according to display.precision #60503
Tests added and passed:
All code checks passed
Added type annotations for clarity in modified functions
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file:
- Enhanced print_thing to respect display.precision setting for Real numbers
This PR modifies the print_thing function to respect display.precision settings when formatting Real numbers. For example: