Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Add your org" link, hide "Add your testimonial" one #305

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Dec 31, 2024

This fixes two links that were previously explicitly pointing at the 404 page, after the migration from the old site:

  • the "Add your organization or company" link on the user spotlight page, which used to point to https://pantsbuild.org/register : this still works (appears to be 301 redirect configured in CloudFlare?), and redirects to a GitHub issue template.
  • the "Add your testimionial" link on the testimonials page, which didn't previously exist (https://web.archive.org/web/20230604011655/https://www.pantsbuild.org/docs/testimonials). I've hidden this one to at least not have a wildly broken link in people's face, but we can restore it once we have an appropriate process. (Although I imagine most people looking at the testimonials page will be new users, i.e. not in a position to write a testimonial yet.)

This was noticed by a user on slack: https://pantsbuild.slack.com/archives/C046T6T9U/p1735280301069719. Thanks!

@huonw huonw marked this pull request as ready for review December 31, 2024 02:15
@huonw huonw merged commit c18ae31 into pantsbuild:main Jan 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants