-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade wgpu to 22.0 #402
base: main
Are you sure you want to change the base?
Conversation
Yeah, I'm holding off any other updates to But I'm glad this has already been started! |
Makes total sense! |
One complication with this is the |
If we are going to be nimble enough to continue updating |
I'm curious what the path forward here is, and how I may help. wgpu is now up to 24.0 (they're breaking things fast 😓 ) |
@djsell What's driving the need to upgrade |
In my case it's integration with other crates that have upgraded. Iced is one of them. I was interested in experimenting with Vello (allowing two styles of rendering) as well and similar issue there. |
There may have been a bug fix in there as well that I needed to upgrade for, but I have forgotten at this point. I've been using sid's branch for a while. |
wgpu
versions now use thex.0
rather than the0.x
scheme ie..22.0
is the new0.22
.Unfortunately, Cargo treats these as very different dependencies and versions. This causes the
pixels
crate to become incompatible with projects that are using a newer version ofwgpu
for something else.In this PR, I've upgraded the wgpu version to latest and fixed the relevant API calls with newer args that the compiler mandated (just defaults for now).
Feel free to merge this if you feel this is relevant. Thanks for the great project! 🙌