-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic nix flake #410
base: main
Are you sure you want to change the base?
Add basic nix flake #410
Conversation
Hi. The concern I have for this is that the toolchain file locks the project to the stable release channel. Our CI is setup to build and test with multiple channels. The existence of the toolchain file will override the toolchains used in the CI jobs. And I don't know if there is a way to "override the override". Let alone getting into situations where you have to override the override for the override. It's best to just not force an override in the first place. Other than that, I don't use nix. I cannot fully appreciate any benefits that this PR is adding. I guess I'm indifferent to the nix configuration. It's kind of like committing a VS Code project file or something. Just unused files in the repo that make the file list longer. |
Hi, thanks for commenting, I have made some changes to avoid some problems, in this case and the most important is to remove the rust-toolchain to avoid problems with the CI. I understand your point of not understanding the need to use Nix, in my case it was because I wanted to contribute to this project, and I created this simple flake to have the rust toolchain, so I think it could be useful for other Nix users who want to contribute to this project. |
Ok, sorry for taking so long to get back to this. My follow up question is how will this work out for maintaining the flake and lock file? I have no intention to do so. Will it become outdated or unusable over time if it isn't kept in sync with upstreams? I'm ok accepting this, but I want to know if you or someone else is interested in taking up the maintenance burden. |
Yes, I would be willing to keep the flake updated. To answer your question, it is possible that the flake could become obsolete over time if it isn't kept in sync with the upstreams. (By the way, sorry for answering three weeks later) |
Ok. If you're happy with it in its current state, I will do the merge. |
this pull request adds a fairly simple nix flake that meets the needs of having the rust toolchain installed, plus it adds a rust-toolchain.toml file that includes the wasm and android targets.
you can use the flake with: