-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Custom Flattening for OTEL logs, metrics and traces #1043
base: main
Are you sure you want to change the base?
feat: Custom Flattening for OTEL logs, metrics and traces #1043
Conversation
a80beb2
to
6b4b20d
Compare
@nikhilsinhaparseable can you document the code with expectations similar to this: https://github.com/parseablehq/parseable/pull/1024/files#diff-c45a9621970d114a8f2791b564a0a3dd8bf7825dcf549fae486a98032723c12eR41-R57 The PR is extremely hard to review, given the exploding scope of code, including generated code, I would heavily suggest we consider moving this to the build stage and require build machines to have protoc and hence not have to include the code in the repo and depend on the tonic code generator to do the job of maintaining the code for us. Please also move files into related module e.g. As for fixing the clippy, this issue is caused by including generated code into the repo, which is a bad practice, but given our circumstance, as a short term fix, we can use this: #[allow(clippy::all)]
pub mod proto; |
6b4b20d
to
570a7f4
Compare
We can consider using https://crates.io/crates/opentelemetry-proto |
Pull Request Test Coverage Report for Build 12515237873Details
💛 - Coveralls |
@de-sh removed the pre-compiled and the protobuf files. |
75370b6
to
95a915f
Compare
Is this ready now for merge? |
add proto files for metrics and trace add compiled rust files for metrics and trace protobuf files add separate handlers for OTEL logs, metrics and traces custom flattening added for OTEL logs and metrics
add custom flattening for otel traces use endpoints `/v1/logs` for OTEL logs `/v1/metrics` for OTEL metrics `/v1/traces` for OTEL traces add custom header X-P-Log-Source when using endpint `api/v1/ingest` `otel-logs` for OTEL logs `otel-metrics` for OTEL metrics `otel-traces` for OTEL traces
Co-authored-by: Devdutt Shenoi <[email protected]> Signed-off-by: Nikhil Sinha <[email protected]>
used `opentelemetry-proto` crate deleted compiled rust files and protobuf files
Co-authored-by: Devdutt Shenoi <[email protected]> Signed-off-by: Nikhil Sinha <[email protected]>
b1a3c94
to
08b95c4
Compare
add proto files for metrics and trace
add compiled rust files for metrics and trace protobuf files
add separate handlers for OTEL logs, metrics and traces
custom flattening added for OTEL logs, metrics and traces
use endpoints
/v1/logs
for OTEL logs/v1/metrics
for OTEL metrics/v1/traces
for OTEL tracesadd custom header X-P-Log-Source when using endpint
api/v1/ingest
otel-logs
for OTEL logsotel-metrics
for OTEL metricsotel-traces
for OTEL traces