Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dynamic schema inference casts strings as timestamp #1044

Closed
wants to merge 6 commits into from
Closed

fix: dynamic schema inference casts strings as timestamp #1044

wants to merge 6 commits into from

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Dec 19, 2024 •
edited
Loading

Fixes #XXXX.

Description

  • Fixes timestamp field detection in dynamic schema inference.
  • Operates with the same schema inference step in detect schema API.
  • Improves performance of schema inference step during ingestion by streamlining steps.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Dec 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12426487089

Details

  • 47 of 80 (58.75%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 11.43%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/logstream.rs 0 2 0.0%
src/event/format/mod.rs 44 75 58.67%
Files with Coverage Reduction New Missed Lines %
src/event/format/mod.rs 6 66.16%
Totals Coverage Status
Change from base Build 12411844504: -0.1%
Covered Lines: 2075
Relevant Lines: 18154
💛 - Coveralls

@de-sh de-sh changed the title perf: use hashset and merge timestamp inference fix: dynamic schema inference cast strings as timestamp Dec 19, 2024
@de-sh de-sh changed the title fix: dynamic schema inference cast strings as timestamp fix: dynamic schema inference casts strings as timestamp Dec 19, 2024
@de-sh
Copy link
Contributor Author

de-sh commented Dec 19, 2024

To test this we should update quest to make calls on schema detection API @nikhilsinhaparseable

de-sh
de-sh commented Dec 20, 2024
View reviewed changes
src/event/format/mod.rs
}
}
}
if field.name() == field_name && field.data_type() == &DataType::Utf8 {
Copy link
Contributor Author

@de-sh de-sh Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the field has a non-utf8, non-timestamp type?

@de-sh de-sh marked this pull request as draft December 26, 2024 05:30
@de-sh de-sh closed this Jan 2, 2025
@de-sh de-sh deleted the perf-infer branch January 2, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitisht nitisht Awaiting requested review from nitisht

@nikhilsinhaparseable nikhilsinhaparseable Awaiting requested review from nikhilsinhaparseable

Assignees
No one assigned
Labels
for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@de-sh @coveralls @nitisht