Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clap_completion #1056

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TwistingTwists
Copy link
Contributor

  • autocompletion for the cli

No issue created yet.

Description

Adding auto completion for the cli - to ease developer UX.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

- autocompletion for the cli
@TwistingTwists
Copy link
Contributor Author

TwistingTwists commented Dec 26, 2024

Questions about this PR:

  1. it changes the CONFIG struct. Since, CONFIG is used almost everywhere in code, it'll cause lots of small changes across codebase. The changes will look like this

  2. Currently the new enum ParseableCommand delegates the methods related to Config struct in impl ParseableCommand.
    I think this could be handled by defining a trait .

Is there an alternate approach I haven't considered that you would like me to try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant