-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conditionalize generic flattening and type casting for streams v1+ #1057
base: main
Are you sure you want to change the base?
Conversation
@@ -84,7 +84,7 @@ pub async fn ingest_internal_stream(stream_name: String, body: Bytes) -> Result< | |||
tags: String::default(), | |||
metadata: String::default(), | |||
}; | |||
event.into_recordbatch(&schema, None, None)? | |||
event.into_recordbatch(&schema, None, None, SchemaVersion::V0)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a comment explaining what is V0 vs V1 (and what is the different)
Pull Request Test Coverage Report for Build 12579727646Details
💛 - Coveralls |
203c1fc
to
16c8954
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add detailed comments especially in places we're checking for versions. Also we need comments on what is v0
Fixes #XXXX.
Description
This PR has: