Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for crash when compiling module with no parameters. #128

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

gjcoram
Copy link

@gjcoram gjcoram commented May 31, 2024

See #103

@gjcoram
Copy link
Author

gjcoram commented Jun 19, 2024

This is the correct commit. Apparently, having a dummy parameter interns the empty string (possibly the unit or description of the parameter), so that the later lookup of the empty string finds a match.

@dwarning
Copy link

@gjcoram
It seems that this patch follows in a crash compiling psphv version 1.0.6 (see https://github.com/dwarning/VA-Models/tree/main/code/psphv/vacode). Log file attached:
openvaf-crash-1721544959.log

@Kreijstal
Copy link

@gjcoram
Update README.md to point to this repository instead of pascalkuthe

I guess you went and officially forked this? are you mantaining it?

@gjcoram
Copy link
Author

gjcoram commented Sep 30, 2024

I guess you went and officially forked this? are you mantaining it?

I hope to continue to improve it.

@Kreijstal
Copy link

I get something weird

thread 'main' panicked at openvaf/openvaf/tests/integration.rs:210:9:
assertion failed: `(left approx_eq right)`
  left: `624.0`,
 right: `78.0`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test noise                        ... test panicked: assertion failed: `(left approx_eq right)`
  left: `624.0`,
 right: `78.0`
FAILED

 failures:

    noise
test result: FAILED. 1 passed; 1 failed; 26 ignored; 0 filtered out; finished in 0.10s

trying to merge this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants