refactor: drop superfluous trait bounds #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's recommended to leave them out of struct definitions and instead have them in impl blocks https://stackoverflow.com/questions/49229332/should-trait-bounds-be-duplicated-in-struct-and-impl
arguably less impactful, but nice-to-have nevertheless
this was made ppossible by removing them from `Interner`
this was made possible by all the previous commits -- `InternedInput` now doesn't require the traits by itself, nor does `Interner::num_tokens`
Byron
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Thanks, this looks great to me!
I'd merge, but think @pascalkuthe should have the final word on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the first commit, it's recommended to avoid putting trait bounds in structs, since causes the bounds to be propagated across the codebase for no added benefit.