Added remove_texts method in WeaviateSearch #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,6 +71,15 @@ def update_texts(texts:, ids:) | |||
| end | |||
| end | |||
|
|
|||
| def remove_texts(ids:) | |||
There was a problem hiding this comment.
@capak07 Thoughts on using the batch_delete method?
There was a problem hiding this comment.
Sorry didn't see this, wanted to check on what would be the right path for the where param, I had something like this
{ path: [\"__id\"], operator: Equal, valueString: \"#{ids}\" ?
There was a problem hiding this comment.
Batch delete docs: https://weaviate.io/developers/weaviate/api/rest/batch#batch-delete
But take a look at the where filter specs: https://weaviate.io/developers/weaviate/api/graphql/filters#where-filter
You may need to use `"ContainsAny":
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove_textsmethods to allLangchain::Vectorsearch::*classes #512