Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove to_bool gem #729

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Azdaroth
Copy link
Contributor

License finder reported one more issue besides colorize - that to_bool has undefined license (which is odd as it clearly has MIT license, but apparently something is off with the gem's metadata). Seems like the best solution was to drop the gem and just implement a simple utility function:

@andreibondarev andreibondarev self-requested a review August 19, 2024 02:34
@andreibondarev
Copy link
Collaborator

@Azdaroth Looks good!

@andreibondarev andreibondarev merged commit f27debb into patterns-ai-core:main Aug 19, 2024
5 checks passed
@Azdaroth Azdaroth deleted the remove-to-bool-gem branch August 19, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants