test: switch from should style to expect
#1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches from using `should` assertions (e.g. `foo.should.equal(303)`) to `expect` assertions (e.g. `expect(foo).to.equal(303)`). This is a stepping stone to moving off `sinon` and possibly `chai` in future.
|
just found why one of the tests was flaky too! it was waiting for 3 events instead of 5... so fixed it while i was in there |
|
Why don’t we just move to assert? Or maybe assert has expect inside? |
|
I am not a huge fan of assert, but at least it is everywhere |
|
We are moving to assert, I'm just not doing it in one massive PR as it'll be difficult to review
Roughly this is my plan |
43081j
added a commit
that referenced
this pull request
Jan 24, 2025
Migrates away from chai's `expect` assertions to `node:assert`. Depends on #1408
|
i've opened #1409 which we can aim to merge once this PR lands then we will have moved to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from using
shouldassertions (e.g.foo.should.equal(303)) toexpectassertions (e.g.expect(foo).to.equal(303)).This is a stepping stone to moving off
sinonand possiblychaiin future.FYI this was automated using an ast-grep codemod found here (which itself has tests)