This repository has been archived by the owner on May 9, 2023. It is now read-only.
Support for Singletons #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @magnumrocha , thanks for your PR! That's a great addition that never had the time to implement. I'm not updating this addon for a long time and therefore I'll need some time to review and merge the PR. |
pauloamgomes
reviewed
May 5, 2022
| @@ -1,4 +1,4 @@ | |||
| <?php | |||
| <?php | |||
| if (!isset($collections[$data['_collection']])) { | ||
| $collection = $this->app->module('collections')->collection($data['_collection']); | ||
| $collections[$data['_collection']] = $collection; | ||
| foreach ($results['active'] as $result) { |
There was a problem hiding this comment.
probably could we decouple better singletons from collections functionality, and reduce the size of the run function
| @@ -34,7 +34,7 @@ | |||
| $options['fields'][$field_name] = 1; | |||
| } | |||
|
|
|||
| $app->trigger("moderation.find.before", [$name, &$options]); | |||
| $app->trigger("moderation.collections.find.before", [$name, &$options]); | |||
There was a problem hiding this comment.
this is a breaking change, would be possible to maintain the moderation.find.before hook and then call the functionality depending on what we have there? its fine on having the new hooks, just concerned on removing the existing one as any addons that rely on it will break
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Moderation support for Singletons registers