Sammy pr feedback

paypal · Feb 26, 2024 · 3bcb8eb · 3bcb8eb
1 parent 3ab587a
commit 3bcb8eb
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,7 +15,7 @@
   * Support VoiceOver by adding button accessibility labels
   * Font typeface changed to "PayPalOpen" to meet brand guidelines
 * CardPayments
-  * Add `cardDidCancelVault()` to `CardVaultDelegate`
+  * Add `cardDidCancelThreeDSecure()` to `CardVaultDelegate`
   * Add `cardThreeDSecureWillLaunch()` to `CardVaultDelegate`
   * Add `cardThreeDSecureDidFinish()` to `CardVaultDelegate`
 * PayPalWebPayments

diff --git a/Demo/Demo/ViewModels/CardVaultViewModel.swift b/Demo/Demo/ViewModels/CardVaultViewModel.swift
@@ -59,7 +59,7 @@ class CardVaultViewModel: VaultViewModel, CardVaultDelegate {
         setUpdateSetupTokenResult(vaultError: vaultError)
     }
 
-    func cardDidCancelVault(_ cardClient: CardClient) {
+    func cardDidCancelThreeDSecure(_ cardClient: CardClient) {
         DispatchQueue.main.async {
             self.state.updateSetupTokenResponse = .idle
             self.state.updateSetupToken = nil

diff --git a/Sources/CardPayments/CardClient.swift b/Sources/CardPayments/CardClient.swift
@@ -204,7 +204,7 @@ public class CardClient: NSObject {
     }
 
     private func notifyVaultCancellation() {
-        vaultDelegate?.cardDidCancelVault(self)
+        vaultDelegate?.cardDidCancelThreeDSecure(self)
     }
 }
 

diff --git a/Sources/CardPayments/CardVaultDelegate.swift b/Sources/CardPayments/CardVaultDelegate.swift
@@ -18,10 +18,10 @@ public protocol CardVaultDelegate: AnyObject {
     ///   - didFinishWithError: the error returned by the Card vault flow
     func card(_ cardClient: CardClient, didFinishWithVaultError vaultError: CoreSDKError)
 
-    /// Notify that the Card vault flow has been cancelled
+    /// Notify that the ThreeDSecure has been cancelled
     /// - Parameters:
     ///   - client: the CardClient associated with delegate
-    func cardDidCancelVault(_ cardClient: CardClient)
+    func cardDidCancelThreeDSecure(_ cardClient: CardClient)
 
     /// Notify that the 3DS challenge will be launched
     /// - Parameters:

diff --git a/UnitTests/CardPaymentsTests/CardClient_Tests.swift b/UnitTests/CardPaymentsTests/CardClient_Tests.swift
@@ -5,8 +5,7 @@ import AuthenticationServices
 @testable import CardPayments
 @testable import TestShared
 
-// swiftlint:disable type_body_length
-// swiftlint:disable file_length
+// swiftlint:disable type_body_length file_length
 class CardClient_Tests: XCTestCase {
 
     // MARK: - Helper Properties

diff --git a/UnitTests/CardPaymentsTests/Mocks/MockCardVaultDelegate.swift b/UnitTests/CardPaymentsTests/Mocks/MockCardVaultDelegate.swift
@@ -31,7 +31,7 @@ class MockCardVaultDelegate: CardVaultDelegate {
         failure?(cardClient, vaultError)
     }
 
-    func cardDidCancelVault(_ cardClient: CardClient) {
+    func cardDidCancelThreeDSecure(_ cardClient: CardClient) {
         cancel?(cardClient)
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -204,7 +204,7 @@ public class CardClient: NSObject { @@
         }
         private func notifyVaultCancellation() {
-            vaultDelegate?.cardDidCancelVault(self)
+            vaultDelegate?.cardDidCancelThreeDSecure(self)
         }
     }
@@ Expand Down @@