Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release bug for accurate SDK version # in analytics #230

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix release bug for accurate SDK version # in analytics #230

merged 1 commit into from
Dec 19, 2023

Conversation

scannillo
Copy link
Collaborator

Reason for changes

  • I noticed in our analytics that all events from iOS are registered as c_sdk_ver = 0.0.3. This is inaccurate, as many merchants have since updated from that version.
  • Turns out our release.yml wasn't actually bumping the version #

See sample data set

Screenshot 2023-12-15 at 5 06 27 PM

Summary of changes

  • Bump the SDK version # in PayPalCoreConstants.swift in our release GH action

Checklist

  • Added a changelog entry

Authors

@scannillo

@scannillo scannillo requested a review from a team as a code owner December 15, 2023 23:10
@scannillo scannillo merged commit 502be1e into main Dec 19, 2023
4 checks passed
@scannillo scannillo deleted the fix-release-version-bug branch December 19, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richherrera richherrera richherrera approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scannillo @jaxdesmarais @richherrera