Updated with PayPalOpen font #237
Conversation
|
Since the change is in the font typeface and isn't breaking, nor do Merchants need to make any changes, does the change still need to be included in the CHANGELOG? |
I would classify changing UI without a merchant having to opt-in to that change, as a breaking change. Even though it's super minor (in this case of a font that doesn't look too different), by the book it would be breaking. We could classify this is a "bug-fix to meet brand guidelines" if we want to get it into V1 😆. Sketchy? Thoughts? |
I think classifying this as a bug fix makes sense! I assume there is some "brand reputation" to actually using the correct fonts so could make sense for a minor version + changelog update. |
Got it, that makes sense! I read through the Semantic Versioning Guideline and must've overlooked UI related changes. In that case, we can have it go into V2 where we have other breaking changes instead. |
You definitely didn't! UI specific stuff isn't clearly defined in there. I like Jax's thoughts - I'm also down for lumping into V1! |
| case .mini, .collapsed, .expanded, .full: | ||
| return UIFont(name: "PayPalOpen-Regular", size: 14) ?? | ||
| .systemFont(ofSize: UIFont.systemFontSize) |
There was a problem hiding this comment.
FYI: Button sizes will reduce to .mini and .expanded in another PR
…on-typeface-update # Conflicts: # CHANGELOG.md
* Added regular font file back to Demo app
Demo/Demo/Info.plist
Outdated
| @@ -2,6 +2,10 @@ | |||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | |||
| <plist version="1.0"> | |||
| <dict> | |||
| <key>UIAppFonts</key> | |||
There was a problem hiding this comment.
Do we have a ticket to add documentation for this for merchants? It seems like this is something that a merchant would need to do to use our fonts. What happens if they don't add this to their Info.plist?
There was a problem hiding this comment.
This line was added in the CHANGELOG under Payment Buttons so that merchants know about the font change: Font typeface changed to "PayPalOpen" to meet brand guidelines
The font shouldn't be in Info.plist so I've removed it. The font is registered in the SDK under the PaymentButtonFont file so that merchants won't need to add the font themselves
Co-authored-by: Rich Herrera <[email protected]>
Reason for changes
Need to update fonts for Payment Buttons to
PayPalOpenfont as the primary font as part of QL.Summary of changes
Checklist
Authors
@stechiu