Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Demo App Funding Source #239

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

jaxdesmarais
Copy link
Collaborator

Reason for changes

The funding source tags were flipped for PayPal Pay Later and PayPal Credit in the Demo app.

Summary of changes

  • Associate PayPalWebCheckoutFundingSource with the correct tags/buttons - clicking on the expected picker button will now lead to the expected PayPal Pay Later or PayPal Credit flow and button

Visuals

Before After
Simulator Screen Recording - iPhone 15 - 2024-01-10 at 11 16 06 Simulator Screen Recording - iPhone 15 - 2024-01-10 at 11 14 56

Checklist

  • [ ] Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner January 10, 2024 17:22
@KunJeongPark
Copy link
Collaborator

Thank you!

Copy link
Contributor

@stechiu stechiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaxdesmarais jaxdesmarais merged commit b39b179 into main Jan 10, 2024
4 checks passed
@jaxdesmarais jaxdesmarais deleted the fix-demo-app-funding-source branch January 10, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants