Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Button Sizes #241

Merged
merged 15 commits into from
Jan 29, 2024
Merged

Update Button Sizes #241

merged 15 commits into from
Jan 29, 2024

Conversation

stechiu
Copy link
Contributor

@stechiu stechiu commented Jan 11, 2024 •
edited
Loading

Reason for changes

Need to update the sizes to match QL button redesign

Summary of changes

  • Reduced from 4 button sizes to 2 .mini and .regular
  • .mini is now rectangular to match Figma redesign
  • Changed edge insets for .mini to match Figma redesign
Figma PR
Screenshot 2024-01-11 at 1 25 37 PM Screenshot 2024-01-11 at 1 28 51 PM

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@stechiu stechiu requested a review from a team as a code owner January 11, 2024 23:06
jaxdesmarais
jaxdesmarais reviewed Jan 16, 2024
View reviewed changes
Sources/PaymentButtons/PayPalButton.swift Outdated Show resolved Hide resolved
Sources/PaymentButtons/PayPalButton.swift Outdated Show resolved Hide resolved
Sources/PaymentButtons/PayPalCreditButton.swift Outdated Show resolved Hide resolved
Sources/PaymentButtons/PayPalPayLaterButton.swift Outdated Show resolved Hide resolved
@stechiu stechiu changed the title Update to Button Sizes Update Button Sizes Jan 21, 2024
agedd
agedd reviewed Jan 25, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
agedd
agedd approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@agedd agedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ~ just left a few small comments 🚀

@stechiu stechiu requested a review from vradopp January 26, 2024 20:25
jaxdesmarais
jaxdesmarais approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name PaymentButtonSize.regular feels a bit odd to me for some reason. Not sure if PaymentButtonSize.standard feels better to you as well. Code looks good overall so I'll leave it up to you if changing regular to standard reads a bit better!

richherrera
richherrera approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@richherrera richherrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@stechiu
* Fixed failing test
643a409 
* Changed from `.regular` to `.standard`
@stechiu stechiu merged commit f20b747 into next-major-version Jan 29, 2024
4 checks passed
@stechiu stechiu deleted the button-sizes branch January 29, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scannillo scannillo scannillo left review comments

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

@agedd agedd agedd approved these changes

@richherrera richherrera richherrera approved these changes

@vradopp vradopp Awaiting requested review from vradopp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stechiu @jaxdesmarais @scannillo @agedd @vradopp @richherrera