Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Environment URLs #256

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Update Environment URLs #256

merged 2 commits into from
Mar 19, 2024

Conversation

sshropshire
Copy link
Collaborator

Summary of changes

Checklist

- [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@KunJeongPark
Copy link
Collaborator

KunJeongPark commented Feb 20, 2024

Steven, what do you think about the fact that confirm-payment-source and updateSetupToken return url's without -m

@sshropshire
Copy link
Collaborator Author

Steven, what do you think about the fact that confirm-payment-source and updateSetupToken return url's without -m

If the API response contains links with api instead of api-m it's probably fine. I'm going off that document that Tim shared that says to prefer the -m URLs for communicating with PayPal APIs.

case .live:
return URL(string: "https://api.paypal.com")!
return URL(string: "https://api-m.paypal.com")!
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I c, so it's more efficient to use this in our network calls overall?

Copy link
Collaborator

@KunJeongPark KunJeongPark Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check all features with new url? I can just run through demo for all the features.
We have no way of testing live environment.

Copy link
Collaborator

@KunJeongPark KunJeongPark Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine on all demo features. Thanks Steven!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I c, so it's more efficient to use this in our network calls overall?

Yeah it seems like it will be because of some CDN network edge optimization.

@jaxdesmarais
Copy link
Collaborator

Just worth calling out that we recently removed the -m on BT iOS and BT Android. Not sure if it's worth digging more into the why. It seems like Sammy discovered it wasn't needed, but maybe that mainly applies to FPTI?

@scannillo
Copy link
Collaborator

Just worth calling out that we recently removed the -m on braintree/braintree_ios#1175 and braintree/braintree_android#896. Not sure if it's worth digging more into the why. It seems like Sammy discovered it wasn't needed, but maybe that mainly applies to FPTI?

Yeh, I wasn't able to track down someone on the API side who could speak to what it did differently than without the -m. I saw a Confluence doc, but it was a few years old without much detail. Would love to see what doc Tim was referencing 👀

The main reason though was that PaymentReady doesn't work with -m. Harish, who owns the PaymentReady API, hasn't heard of -m.

@sshropshire sshropshire merged commit d813b7b into main Mar 19, 2024
4 checks passed
@sshropshire sshropshire deleted the update_env_urls branch March 19, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants