-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Environment URLs #256
Conversation
Steven, what do you think about the fact that |
If the API response contains links with |
case .live: | ||
return URL(string: "https://api.paypal.com")! | ||
return URL(string: "https://api-m.paypal.com")! | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I c, so it's more efficient to use this in our network calls overall?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to check all features with new url? I can just run through demo for all the features.
We have no way of testing live environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work fine on all demo features. Thanks Steven!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I c, so it's more efficient to use this in our network calls overall?
Yeah it seems like it will be because of some CDN network edge optimization.
Just worth calling out that we recently removed the |
Yeh, I wasn't able to track down someone on the API side who could speak to what it did differently than without the The main reason though was that PaymentReady doesn't work with |
Summary of changes
api-m
style URLs for communicating with PayPal APIsChecklist
- [ ] Added a changelog entryAuthors