Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo app - Make Buliding urlRequests Consistent #257

Merged
merged 28 commits into from
Feb 28, 2024
Merged

Demo app - Make Buliding urlRequests Consistent #257

merged 28 commits into from
Feb 28, 2024

Conversation

KunJeongPark
Copy link
Collaborator

@KunJeongPark KunJeongPark commented Feb 26, 2024 •
edited
Loading

Summary of changes

  • Cleaned up creating setupToken and paymentToken in demo app
    using the same buildBaseURL and buildURLRequest.
  • Included option to exclude httpBody for get calls in buildURLRequest function in preparation for get setup token
    endpoint call for vault without purchase 3Ds, get order call for vault with purchase 3DS.

Checklist

- [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@KunJeongPark
Modify setup token for card 3DS, UI for SCA
025fd46
@KunJeongPark
added optional status field and more test cards in UI
52af8c9
@KunJeongPark
add more 3DS contingency, vaultDelegate 3DS functions
36f0497
@KunJeongPark
merge conflicts, fix mockCardVaultDelegate missing functions, amx cvv
5f8e76c
@KunJeongPark
Merge branch 'main' into vaultWithoutPurchase3DS
cf6a77f
@KunJeongPark
unit tests, typo in vm
8bbb376
@KunJeongPark
pr feedback: remove deeplinkURL and add threeDSecureAttempted boolean…
63c46c1 
… in CardVaultResult
@KunJeongPark
pr feedback
3e0d263
@KunJeongPark
change threeDSecureAttempted to didAttemptThreeDSecureAuthentication
b1627dc
@KunJeongPark
CHANGELOG and CardVaultRequest visibility
4221456
@KunJeongPark
CHANGELOG for didAttemptThreeDSecureAuthentication name
2ad8d3f
@KunJeongPark
fix mistake on vault docString
5b5bf54
@KunJeongPark
fix merge conflict
1d59c65
@KunJeongPark
return notifyVaultFailure for invalid 3DS url, tests for 3DS url
51bd15f
@KunJeongPark
steven pr feedback
7f02645
@KunJeongPark
extra space in docStrings
672ad64
@KunJeongPark
CHANGELOG update for cancel delegate function name
6cdd4cf
@KunJeongPark
jax pr feedback, docstrings, sca omit default string
3ab587a
@KunJeongPark
Sammy pr feedback
3bcb8eb
@KunJeongPark
change cancel name to cardThreeDSecureDidCancel
03f83d2
@KunJeongPark
Demo app - make buliding urlRequests consistent
9b8ad42
@KunJeongPark KunJeongPark requested a review from a team as a code owner February 26, 2024 17:34
@KunJeongPark KunJeongPark changed the title Demo app - make buliding urlRequests consistent Demo app - Make Buliding urlRequests Consistent Feb 26, 2024
jaxdesmarais
jaxdesmarais reviewed Feb 26, 2024
View reviewed changes
Demo/Demo/Networking/DemoMerchantAPI.swift Outdated Show resolved Hide resolved
Demo/Demo/Networking/DemoMerchantAPI.swift Outdated Show resolved Hide resolved
Demo/Demo/Networking/DemoMerchantAPI.swift Outdated Show resolved Hide resolved
richherrera
richherrera approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@richherrera richherrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Just small suggestions :)

Demo/Demo/Models/PaymentTokenParam.swift Outdated Show resolved Hide resolved
Demo/Demo/Models/CreateSetupTokenParam.swift Outdated Show resolved Hide resolved
Demo/Demo/Networking/DemoMerchantAPI.swift Outdated Show resolved Hide resolved
Base automatically changed from vaultWithoutPurchase3DS to main February 28, 2024 16:48
@KunJeongPark KunJeongPark merged commit 670138c into main Feb 28, 2024
4 checks passed
@KunJeongPark KunJeongPark deleted the demoAppRequestRefactor branch February 28, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxdesmarais jaxdesmarais jaxdesmarais left review comments

@sshropshire sshropshire sshropshire left review comments

@richherrera richherrera richherrera approved these changes

@warmkesselj warmkesselj warmkesselj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KunJeongPark @jaxdesmarais @sshropshire @richherrera @warmkesselj