Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge resource_bundle declarations #268

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Merge resource_bundle declarations #268

merged 5 commits into from
Apr 24, 2024

Conversation

richherrera
Copy link
Contributor

Reason for changes

Summary of changes

  • Consolidated multiple resource bundle (resource_bundle) declarations into a single block. Previously, having two separate declarations led to only the Privacy Manifest being copied to the target bundle, causing the assets not to display

Checklist

  • Added a changelog entry

Authors

@richherrera richherrera requested a review from a team as a code owner April 23, 2024 21:16
@richherrera richherrera self-assigned this Apr 23, 2024
jaxdesmarais
jaxdesmarais approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

CHANGELOG.md Outdated Show resolved Hide resolved
@richherrera richherrera merged commit d2ccb10 into main Apr 24, 2024
5 checks passed
@richherrera richherrera deleted the resource_bundle_sdk branch April 24, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

@warmkesselj warmkesselj warmkesselj approved these changes

Assignees

@richherrera richherrera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing PayPal logo in generic PayPal button
3 participants
@richherrera @jaxdesmarais @warmkesselj