-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Delegation Pattern to Async-Await #292
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshropshire
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do really like async/await where possible. It makes the code really clean from a maintenance perspective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Discussion:
Created a separate PR for completion handler first version that offers async await wrapper functions.
Thinking ahead to including app switch features, the completion handler version has been tested in Braintree
iOS SDK. I did put up a POC branch
with async await pattern and saw it work by resuming continuation.
Pros of using async await pattern first is setting a pattern where we don't have to refactor bottom up from completion
handler version in the future. Code is much easier to read and unit tests are much easier to implement.
Cons I've experienced working on this PR:
ASWebAuthenticationSession
returns results via completion handlers, so we are having to wrap asignificant portion of the public functions in
withCheckedThrowingContinuation
.I am closing this one in favor of completion handler version
For the merchant, the integration experience will be the same with completion handler first or async await first approach.
Both versions will offer both completion handler and async await versions of the public functions.
Eliminating old delegation pattern with either approach definitely simplifies integration and future development for us.
Checklist
Authors