Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docstrings for returning CoreSDKError #302

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix docstrings for returning CoreSDKError #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/CardPayments/CardClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public class CardClient: NSObject {
/// - Parameters:
/// - vaultRequest: The request containing setupTokenID and card
/// - Returns: `CardVaultResult` if successful
/// - Throws: An `Error` describing failure
/// - Throws: A `CoreSDKError` describing failure
public func vault(_ vaultRequest: CardVaultRequest) async throws -> CardVaultResult {
try await withCheckedThrowingContinuation { continuation in
vault(vaultRequest) { result, error in
Expand Down Expand Up @@ -137,7 +137,7 @@ public class CardClient: NSObject {
/// - orderId: Order id for approval
/// - request: The request containing the card
/// - Returns: `CardResult` if successful
/// - Throws: An `Error` describing failure
/// - Throws: A `CoreSDKError` describing failure
public func approveOrder(request: CardRequest) async throws -> CardResult {
try await withCheckedThrowingContinuation { continuation in
approveOrder(request: request) { result, error in
Expand Down
4 changes: 2 additions & 2 deletions Sources/PayPalWebPayments/PayPalWebCheckoutClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public class PayPalWebCheckoutClient: NSObject {
/// - Parameters:
/// - request: the PayPalRequest for the transaction
/// - Returns: A `PayPalWebCheckoutResult` if successful
/// - Throws: An `Error` describing the failure
/// - Throws: A `CoreSDKError` describing the failure
public func start(request: PayPalWebCheckoutRequest) async throws -> PayPalWebCheckoutResult {
try await withCheckedThrowingContinuation { continuation in
start(request: request) { result, error in
Expand Down Expand Up @@ -184,7 +184,7 @@ public class PayPalWebCheckoutClient: NSObject {
/// - Parameters:
/// - vaultRequest: Request created with url for vault approval and setupTokenID
/// - Returns: `PayPalVaultResult`if successful
/// - Throws: An `Error` describing failure
/// - Throws: A `CoreSDKError` describing failure
public func vault(_ vaultRequest: PayPalVaultRequest) async throws -> PayPalVaultResult {
try await withCheckedThrowingContinuation { continuation in
vault(vaultRequest) { result, error in
Expand Down
Loading