[DTPPMOBILE-143] Deprecate Delegation Methods in Paypal SDK #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for addressing this deprecation issue. It looks like you have some lint failures with line lengths. |
| @@ -34,4 +34,5 @@ jobs: | |||
| run: cd SampleApps/SPMTest && swift package resolve | |||
| - name: Build & archive SPMTest | |||
| run: xcodebuild -project 'SampleApps/SPMTest/SPMTest.xcodeproj' -scheme 'SPMTest' clean build archive CODE_SIGNING_ALLOWED=NO | |||
| run: pod lib lint --allow-warnings="deprecated" | |||
KunJeongPark
approved these changes
Nov 26, 2024
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for changes
The PayPal SDK is transitioned from the delegation pattern to the completion handler approach for handling asynchronous operation. We want to mark the existing delegation methods as deprecated in the 1.X to notify merchants about upcoming change.
Summary of changes
#301
I used the migration-merged PR to deprecate all the methods and protocols that have been removed or renamed.
Checklist
Authors