Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Result type instead of tuple of optionals #316

Merged
merged 7 commits into from
Jan 21, 2025
Merged

Return Result type instead of tuple of optionals #316

merged 7 commits into from
Jan 21, 2025

Conversation

KunJeongPark
Copy link
Collaborator

@KunJeongPark KunJeongPark commented Jan 17, 2025 •
edited
Loading

Summary of changes

  • Return result type with .success and .failure rather than optional of result and errors.

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@KunJeongPark KunJeongPark marked this pull request as ready for review January 21, 2025 17:00
@KunJeongPark KunJeongPark requested a review from a team as a code owner January 21, 2025 17:00
sshropshire
sshropshire approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@sshropshire sshropshire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@KunJeongPark KunJeongPark merged commit 768e971 into main Jan 21, 2025
6 checks passed
@KunJeongPark KunJeongPark deleted the return-result-type branch January 21, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshropshire sshropshire sshropshire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KunJeongPark @sshropshire