remove modal closed event

paypal · May 13, 2024 · c0fb935 · c0fb935
1 parent d19d27f
commit c0fb935
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 12 deletions.
diff --git a/library/src/main/java/com/paypal/messages/ModalFragment.kt b/library/src/main/java/com/paypal/messages/ModalFragment.kt
@@ -120,10 +120,7 @@ internal class ModalFragment(
 		val colorInt = Color.parseColor(this.closeButtonData?.color)
 		closeButton.background.colorFilter = PorterDuffColorFilter(colorInt, PorterDuff.Mode.SRC_ATOP)
 
-		closeButton?.setOnClickListener {
-			logEvent(AnalyticsEvent(eventType = EventType.MODAL_CLOSED))
-			dialog?.hide()
-		}
+		closeButton?.setOnClickListener { dialog?.hide() }
 
 		// If we already have a WebView, don't reset it
 		LogCat.debug(TAG, "Configuring WebView Settings and Handlers")

diff --git a/library/src/main/java/com/paypal/messages/analytics/EventType.kt b/library/src/main/java/com/paypal/messages/analytics/EventType.kt
@@ -18,9 +18,6 @@ enum class EventType {
 	@SerializedName("modal_viewed")
 	MODAL_VIEWED,
 
-	@SerializedName("modal_closed")
-	MODAL_CLOSED,
-
 	@SerializedName("modal_error")
 	MODAL_ERROR,
 	;

diff --git a/library/src/test/java/com/paypal/messages/analytics/EventTypeTest.kt b/library/src/test/java/com/paypal/messages/analytics/EventTypeTest.kt
@@ -29,11 +29,6 @@ class EventTypeTest {
 		assertEquals(EventType.MODAL_VIEWED.toString(), "modal_viewed")
 	}
 
-	@Test
-	fun testModalClose() {
-		assertEquals(EventType.MODAL_CLOSED.toString(), "modal_closed")
-	}
-
 	@Test
 	fun testModalError() {
 		assertEquals(EventType.MODAL_ERROR.toString(), "modal_error")