-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fraudnet): add fraudnet util for shared SDK components #170
Conversation
it might be better to stick with jest and then we can come back and convert the whole repo to vite |
5ff70ae
to
3e32142
Compare
src/constants.js
Outdated
@@ -13,3 +14,15 @@ export const FPTI_TRANSITION = { | |||
export const FPTI_STATE = { | |||
PXP: ("PXP_CHECK": "PXP_CHECK"), | |||
}; | |||
|
|||
export const FRAUDNET_URL = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine for our deadline but we should create a jira ticket to move these urls to csnw. I can help with the details
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 87.95% 81.95% -6.01%
==========================================
Files 20 21 +1
Lines 490 532 +42
Branches 40 40
==========================================
+ Hits 431 436 +5
- Misses 59 96 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…to test-fraudnet
Yup, we did just that actually. We pulled the changes off to a different branch to at least capture our efforts and cleaned this one and verified the changes manually. |
In order to support the latest pattern of pre-loading the fraudnet script and only collecting at the appropriate buyer intent trigger, we want to have the
loadFraudnet
steps available from sdk-client. This will load the script to any component that wants it/invokesloadFraudnet
then provide them with acollect
function to call at the point of buyer intent.Initially this is in service of the new Connect component, but the intent is to bring it to the other integrations over time.