Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fraudnet): add fraudnet util for shared SDK components #170

Merged
merged 22 commits into from
Dec 15, 2023

Conversation

siddy2181
Copy link
Contributor

@siddy2181 siddy2181 commented Nov 27, 2023

In order to support the latest pattern of pre-loading the fraudnet script and only collecting at the appropriate buyer intent trigger, we want to have the loadFraudnet steps available from sdk-client. This will load the script to any component that wants it/invokes loadFraudnet then provide them with a collect function to call at the point of buyer intent.

Initially this is in service of the new Connect component, but the intent is to bring it to the other integrations over time.

@siddy2181 siddy2181 requested a review from a team as a code owner November 27, 2023 20:16
src/fraudnet.js Outdated Show resolved Hide resolved
src/setup.js Outdated Show resolved Hide resolved
@wsbrunson
Copy link
Member

it might be better to stick with jest and then we can come back and convert the whole repo to vite

src/constants.js Outdated
@@ -13,3 +14,15 @@ export const FPTI_TRANSITION = {
export const FPTI_STATE = {
PXP: ("PXP_CHECK": "PXP_CHECK"),
};

export const FRAUDNET_URL = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine for our deadline but we should create a jira ticket to move these urls to csnw. I can help with the details

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (d47dd04) 87.95% compared to head (6937da2) 81.95%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/fraudnet.js 7.50% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   87.95%   81.95%   -6.01%     
==========================================
  Files          20       21       +1     
  Lines         490      532      +42     
  Branches       40       40              
==========================================
+ Hits          431      436       +5     
- Misses         59       96      +37     
Flag Coverage Δ
client 76.64% <11.90%> (-7.37%) ⬇️
server 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgdibble
Copy link
Contributor

cgdibble commented Dec 6, 2023

it might be better to stick with jest and then we can come back and convert the whole repo to vite

Yup, we did just that actually. We pulled the changes off to a different branch to at least capture our efforts and cleaned this one and verified the changes manually.

@siddy2181 siddy2181 merged commit 678c6d8 into main Dec 15, 2023
4 of 5 checks passed
@wsbrunson wsbrunson deleted the test-fraudnet branch April 17, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants