Log JS SDK library #183
Log JS SDK library #183
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 73.68% 73.74% +0.05%
==========================================
Files 23 23
Lines 2037 2045 +8
Branches 240 241 +1
==========================================
+ Hits 1501 1508 +7
- Misses 526 527 +1
Partials 10 10 ☔ View full report in Codecov by Sentry. |
|
we are going to add the default |
@wsbrunson, I'm going to wait on merging this PR, because I'm not totally clear yet on where we're going to enforce values. I'm thinking we should enforce the JS library values in the JS libraries themselves and |
nbierdeman
force-pushed
the
feature/DTPPCPSDK-1482
branch
from
02f2522 to
7dcc530
Compare
nbierdeman
force-pushed
the
feature/DTPPCPSDK-1482
branch
from
01d046e to
5b1d344
Compare
|
codecov is wanting me to write tests for alphabetizing the FPTI keys. 👇 🙃 |
| getCurrentScript.mockReturnValue(mockElement); | ||
|
|
||
| expect(getJsSdkLibrary()).toEqual(jsSdkLibrary); | ||
| }); |
| [FPTI_KEY.LOCALE]: `${lang}_${country}`, | ||
| [FPTI_KEY.CONTEXT_CORRID]: getCorrelationID(), | ||
| [FPTI_KEY.DATA_SOURCE]: FPTI_DATA_SOURCE.PAYMENTS_SDK, | ||
| [FPTI_KEY.FEED]: FPTI_FEED.PAYMENTS_SDK, |
Description
Herein lies part of the effort charged by DTPPCPSDK-1482.
Why are we making these changes?
This sends
jsSdkLibraryto FPTI & SFX for 1st and 2nd render.