Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add log for sdk init and include more properties on every logger call #210

Merged
merged 1 commit into from
Jun 6, 2024
Merged

add log for sdk init and include more properties on every logger call #210

merged 1 commit into from
Jun 6, 2024

Conversation

wsbrunson
Copy link
Member

No description provided.

@wsbrunson wsbrunson requested a review from a team as a code owner June 5, 2024 22:38
nikrom17
nikrom17 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@nikrom17 nikrom17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

nikrom17
nikrom17 reviewed Jun 6, 2024
View reviewed changes
src/tracking.js
csnwCorrelationId: getCorrelationID(),
jsSdkLibrary,
locale: `${lang}_${country}`,
referrer: window.location.host,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this include the full url of the payer view invoice?

i.e.: https://www.paypal.com/invoice/payerView/details/INV2-S8L9-LN49-9RMH-5VDH

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should, as long as they are not rendering the SDK in an iframe which i don't think they are

@wsbrunson wsbrunson force-pushed the sdk-inti-wide-event branch 2 times, most recently from 2f41d91 to 19c1e83 Compare June 6, 2024 16:11
@wsbrunson wsbrunson force-pushed the sdk-inti-wide-event branch from 19c1e83 to ff9e051 Compare June 6, 2024 16:47
@wsbrunson wsbrunson merged commit bdc0d4b into main Jun 6, 2024
2 checks passed
@wsbrunson wsbrunson deleted the sdk-inti-wide-event branch June 6, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikrom17 nikrom17 nikrom17 approved these changes

@ravishekhar ravishekhar ravishekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wsbrunson @ravishekhar @nikrom17