Rename library enum #142
Merged
Rename library enum #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbierdeman
changed the title
jshawl
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
(sanity checking - does the existing constant need to remain in-place to prevent a failed build in paypal-checkout-components)? e.g.: add a new variable JS_SDK_LIBRARIES then change checkout components, then come back and delete? just looking out - I think you'd be able to make the checkout components change before the next publish
wsbrunson
approved these changes
Feb 13, 2024
nbierdeman
force-pushed
the
feature/DTPPCPSDK-1482v2
branch
from
bc2f2b8 to
d3cab41
Compare
jshawl
approved these changes
Mar 12, 2024
| USER_EXPERIENCE_FLOW: | ||
| ("data-user-experience-flow": "data-user-experience-flow"), | ||
| POPUPS_DISABLED: ("data-popups-disabled": "data-popups-disabled"), | ||
| SDK_TOKEN: ("data-sdk-client-token": "data-sdk-client-token"), | ||
| USER_ID_TOKEN: ("data-user-id-token": "data-user-id-token"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have decided on a new name for tracking library usage, thus this PR. Alphabetization is in a separate commit, so it's easier to see the core changes. The original PR is here.
JIRA
DTPPCPSDK-1482