Release v4.2.0: PHP 7.1 support (v5.1.2 synced)

payvision-development · Oct 5, 2020 · b729970 · b729970
1 parent 46828a2
commit b729970
Show file tree

Hide file tree

Showing 135 changed files with 1,155 additions and 1,167 deletions.
diff --git a/SECURITY.md b/SECURITY.md
diff --git a/composer.json b/composer.json
@@ -2,10 +2,10 @@
     "name": "payvision/payvision-sdk-php",
     "description": "Payvision PHP SDK",
     "type": "library",
-    "version": "5.1.2",
+    "version": "4.2.0",
     "license": "MIT",
     "require": {
-        "php": "^7.2.5|^7.3",
+        "php": "~7.1.3||~7.2.0||~7.3.0",
         "ext-simplexml": "*",
         "ext-json": "*",
         "ext-curl": "*",
@@ -23,11 +23,11 @@
         }
     },
     "require-dev": {
-        "phpunit/phpunit": "^8.5",
+        "phpunit/phpunit": "^7.5",
         "dealerdirect/phpcodesniffer-composer-installer": "^0.7.0",
-        "object-calisthenics/phpcs-calisthenics-rules": "^3.8",
+        "object-calisthenics/phpcs-calisthenics-rules": "^3.5",
         "phpcompatibility/php-compatibility": "^9.3",
-        "slevomat/coding-standard": "^6.3",
+        "slevomat/coding-standard": "^5.0",
         "squizlabs/php_codesniffer": "^3.5"
     }
 }
diff --git a/phpcs.xml b/phpcs.xml
@@ -14,23 +14,33 @@
     <exclude-pattern>./vendor</exclude-pattern>
 
     <!-- This code is generated and therefore excluded from static code analysis: -->
-    <exclude-pattern>./src/Domain/Payments</exclude-pattern>
-    <exclude-pattern>./src/Domain/Checkouts</exclude-pattern>
-    <exclude-pattern>./src/Domain/Paymentlink</exclude-pattern>
-    <exclude-pattern>./src/Application/Payments</exclude-pattern>
-    <exclude-pattern>./src/Application/Checkouts</exclude-pattern>
-    <exclude-pattern>./src/Application/Paymentlink</exclude-pattern>
+    <!-- Release 4.2 is a manual release, check all files -->
+    <!-- <exclude-pattern>./src/Domain/Payments</exclude-pattern> -->
+    <!-- <exclude-pattern>./src/Domain/Checkouts</exclude-pattern> -->
+    <!-- <exclude-pattern>./src/Domain/Paymentlink</exclude-pattern> -->
+    <!-- <exclude-pattern>./src/Application/Payments</exclude-pattern> -->
+    <!-- <exclude-pattern>./src/Application/Checkouts</exclude-pattern> -->
+    <!-- <exclude-pattern>./src/Application/Paymentlink</exclude-pattern> -->
 
     <!-- Arguments -->
     <arg value="sp"/>
     <arg name="colors"/>
 
     <!-- PSR2 standard -->
-    <rule ref="PSR2"/>
+    <rule ref="PSR2">
+        <!-- Release 4.2 contains some autogenerated filed with errors. Accept them -->
+        <exclude name="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly.ReferenceViaFullyQualifiedName" />
+        <exclude name="SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses" />
+        <exclude name="Generic.Files.LineLength.TooLong" />
+        <exclude name="SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse" />
+        <exclude name="Squiz.Functions.MultiLineFunctionDeclaration.EmptyLine" />
+        <exclude name="Squiz.WhiteSpace.SuperfluousWhitespace.EndLine" />
+        <exclude name="Squiz.Functions.MultiLineFunctionDeclaration.FirstParamSpacing" />
+    </rule>
 
     <!-- PHP compatibility -->
     <rule ref="PHPCompatibility"/>
-    <config name="testVersion" value="7.2-"/>
+    <config name="testVersion" value="7.0-7.1"/>
 
     <!-- Extra rules -->
     <rule ref="Generic.Arrays.ArrayIndent"/>
@@ -75,12 +85,14 @@
     </rule>
     <rule ref="ObjectCalisthenics.Metrics.MethodPerClassLimit">
         <properties>
-            <property name="maxCount" value="10"/>
+            <!-- Release 4.2 has some generated files, accept them -->
+            <property name="maxCount" value="20"/>
         </properties>
     </rule>
     <rule ref="ObjectCalisthenics.Metrics.PropertyPerClassLimit">
         <properties>
-            <property name="maxCount" value="10"/>
+            <!-- Release 4.2 has some generated files, accept them -->
+            <property name="maxCount" value="25"/>
         </properties>
     </rule>
     <rule ref="SlevomatCodingStandard.Classes.UnusedPrivateElements"/>
@@ -106,9 +118,6 @@
     </rule>
     <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing"/>
     <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing"/>
-    <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingAnyTypeHint"/>
-    <rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingAnyTypeHint"/>
-    <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingAnyTypeHint"/>
     <rule ref="SlevomatCodingStandard.TypeHints.UselessConstantTypeHint"/>
     <rule ref="SlevomatCodingStandard.Classes.EmptyLinesAroundClassBraces">
         <properties>