Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved localization and added Turkish/other language translations #1214

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

0FSener
Copy link
Contributor

@0FSener 0FSener commented Dec 25, 2024

Summary

While learning Git through this project, I noticed that some translations were missing or incomplete in various languages, including Turkish. After discovering that contributions to localization are welcome, I decided to help complete the missing translations and improve existing ones.

It brings me great joy to give back to a project that has been so helpful to me. I hope these contributions make the learning experience even better for others.


Changes Made

  • Added missing Turkish translations and improved existing ones.
  • Fixed incomplete or inconsistent translations in other languages.
  • Enhanced cultural appropriateness and user clarity in multiple language files.

Modified Files

A total of 33 files were modified, with 2618 insertions and 324 deletions. The files include:

  1. learnGitBranching/src/js/intl/strings.js
  2. learnGitBranching/src/js/stores/LocaleStore.js
  3. Levels files under learnGitBranching/src/levels/:
    • intro/branching.js
    • advanced/multipleParents.js
    • mixed/jugglingCommits.js
    • (and others; full list is in the commit details)

Purpose

These changes aim to:

  • Ensure a seamless learning experience for Turkish-speaking users.
  • Enhance the quality of localization in other languages by addressing gaps and inaccuracies.
  • Improve the overall accessibility of the project for users worldwide.

Notes

  1. All changes were carefully tested to ensure they do not break existing functionality.
  2. Suggestions for further refinement are welcome.
  3. I’m open to feedback and ready to make additional adjustments based on the review.

Acknowledgment

I would like to express my gratitude to the maintainers of this project for creating such a fantastic resource for learning Git. It has been incredibly helpful to me, and I’m thrilled to contribute back to something that has had a positive impact on my learning journey.

Thank you for considering this contribution!

Copy link

netlify bot commented Dec 25, 2024

Deploy Preview for xenodochial-hugle-b9ec84 ready!

Name Link
🔨 Latest commit fd74380
🔍 Latest deploy log https://app.netlify.com/sites/xenodochial-hugle-b9ec84/deploys/676c532634ebbf0008177915
😎 Deploy Preview https://deploy-preview-1214--xenodochial-hugle-b9ec84.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pcottle
Copy link
Owner

pcottle commented Dec 25, 2024

Wow this is an incredible contribution @0FSener, its huge!! Thanks for fixing up some of those JSON keys as well (we should be consistent with using the strings).

Generally I prefer to merge in net-new translations instead of wait for others to provide feedback, and given that you've added so many, I'm excited to get these out onto the site so other Turkish learners can benefit ASAP 😇 It'll be a little christmas miracle for those who celebrate 🎄

@pcottle pcottle merged commit a95cb0e into pcottle:main Dec 25, 2024
5 checks passed
@pcottle
Copy link
Owner

pcottle commented Dec 25, 2024

(pushing the site now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants