Fix/v4 compatibility #16
Conversation
|
Can you confirm whether split navigation and dropdowns still function correctly with v4.x? Please drop the version bump commit - I'll need to bump the major version since we'll be changing the simple-navigation dependency, and there is a rake task that will handle this for release. |
|
If by "split navigation" you mean "sub-navigation," then yes, both features still function correctly with v4.x because I am using them both in our code. I have reverted the version file to the current master version, so only two files are now changed. |
|
If you take a look at the README, there's a split navigation feature that creates a separate dropdown toggle, so that the primary button can function with a link. I just have no way to test this easily right now. |
|
Working on this now. I have run into an unrelated problem with my app during the test. I'll let you know shortly when the test is complete. |
|
The test will not be happening tonight. |
|
No problem, take your time. |
Prior to this commit split:true was not working properly, nor were dividers. This commit fixes a number of places where the structure of the Item class changed between versions, including changes where attributes which were not exposed were accessed.
Thor versions 19.2-19.4 generate these warning messages: Expected string default value for '--helper'; got true (boolean) Expected string default value for '--assets'; got true (boolean) Expected string default value for '--decorator'; got true (boolean) Expected string default value for '--decorator'; got true (boolean) Expected string default value for '--serializer'; got true (boolean) Thor is used in rails and jquery-ui, among other gems. None of them locks the version. This commit requests at least version 19.1 and refuses to load .2, .3 or .4. The assumption is that this will be fixed in the next release and this fix should only prove a problem if it is not AND some other gem is updated.
| @@ -20,4 +20,6 @@ Gem::Specification.new do |s| | |||
| s.add_development_dependency "rake" | |||
| s.add_runtime_dependency "simple-navigation", ">= 4.0.0" | |||
| s.add_runtime_dependency "railties", ">= 3.1" | |||
| # thor dependencies assume the spurious warning messages bug will be fixed 19.5 | |||
| s.add_runtime_dependency "thor", "0.19.1", "!=0.19.2", "!=0.19.3", "!=0.19.4" | |||
There was a problem hiding this comment.
Should probably only be a development dependency.
|
Do you suspect this is close to ready for review? |
The WF2 nav bar needs to use the
link_htmlfeature of thesimple-navigationgem, but that feature was added in V4 and ourGemfileis locked at V3 because it uses thesimple-navigation-bootstrapgem which has not had a maintainer since 2015 and does not support V4. There is a PR against the*-bootstrapsource that updated the gem for the V4 changes, but it introduced a bug in theicon:code.This PR incorporates that V4 update PR and fixes the
icon:bug. The intent is to maintain this gem privately until such time as a maintainer comes forward.