Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to PHP 8 #4

Merged
merged 9 commits into from
Nov 26, 2024
Merged

Port to PHP 8 #4

merged 9 commits into from
Nov 26, 2024

Conversation

duboism
Copy link
Contributor

@duboism duboism commented Nov 25, 2024

This PR ports the code to PHP 8: it now runs from PHP 5.6 to PHP 8.4.

The main changes to the code are:

  • don't use curly braces for accessing array elements (0fd9ba2)
  • some static methods were not declared as static (4e05aff and fb8a227)

This PR is based on the branch used for PR #3 (so this one must be merged first and I must rebase).

@CloCkWeRX
Copy link
Member

CloCkWeRX commented Nov 26, 2024

Probably better to target https://github.com/pear/Image_Color2 but oh well we have merged newer content to this repo.

@duboism
Copy link
Contributor Author

duboism commented Nov 26, 2024

Probably better to target https://github.com/pear/Image_Color2 but oh well we have merged newer content to this repo.

I worked on this repo because pear/Image_Canvas uses it (and my project uses Image_Canvas). It was done at the beginning of 2024 (there was some exchange on the ML around that). I can have a look at pear/Image_Color2 too (but not right now).

@duboism
Copy link
Contributor Author

duboism commented Nov 26, 2024

Ah, thanks for solving the conflicts. This extra line is weird (probably a mistake on my side), I think we should remove it.

@CloCkWeRX CloCkWeRX merged commit 8d7f765 into pear:master Nov 26, 2024
18 checks passed
@duboism
Copy link
Contributor Author

duboism commented Nov 26, 2024

Thanks for your work (I was a bit busy today) and merging this.

@duboism duboism deleted the port_php8 branch November 26, 2024 21:44
@Neustradamus
Copy link

Thanks to @duboism for this PR and @CloCkWeRX for merging!
Good job!

@CloCkWeRX: Can you add "Issues" section for:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants