-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to PHP 8 #4
Conversation
We test up to PHP 7.4 for now
Probably better to target https://github.com/pear/Image_Color2 but oh well we have merged newer content to this repo. |
I worked on this repo because pear/Image_Canvas uses it (and my project uses Image_Canvas). It was done at the beginning of 2024 (there was some exchange on the ML around that). I can have a look at pear/Image_Color2 too (but not right now). |
Ah, thanks for solving the conflicts. This extra line is weird (probably a mistake on my side), I think we should remove it. |
Thanks for your work (I was a bit busy today) and merging this. |
Thanks to @duboism for this PR and @CloCkWeRX for merging! @CloCkWeRX: Can you add "Issues" section for: |
This PR ports the code to PHP 8: it now runs from PHP 5.6 to PHP 8.4.
The main changes to the code are:
This PR is based on the branch used for PR #3 (so this one must be merged first and I must rebase).