Update Ubuntu and other Github Action versions in CI #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just keeps us up to date and avoids warnings for deprecated Node.js versions in CI.
This doesn't really save us much effort and breaks CI on forks. Connects pelias/pelias#951
BREAKING CHANGE: The Docker baseimage has been updated to use Node.js 18.20.5, so this repository's Docker image will also use it. pelias/pelias#950
orangejulius
changed the title
orangejulius
changed the title
missinglink
approved these changes
Nov 29, 2024
| @@ -6,12 +6,12 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: | |||
| - ${{ vars.UBUNTU_VERSION }} | |||
| - ubuntu-22.04 | |||
There was a problem hiding this comment.
for these would it make sense to have it overridable but also provide a default such as:
${{ vars.UBUNTU_VERSION || 'ubuntu-22.04' }}
There was a problem hiding this comment.
Or even better, is it possible to derive that string from our org if not defined in the org of a fork?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a bunch of commits made by a script that standardizes as much as possible our CI config across all repositories.
Along the way it also ensures we test all Node.js versions that are an LTS release, not EOL, and currently work with this repository. Any Github Actions that were out of date or used old Node.js versions (checkout and setup-node @v2) are also updated.
For the schema repository, 20 and 22 support was added in #497, so fortunately we were already totally up to date with Node.js versions, so nothing had to be done.
Also, the CI OS version is now hardcoded to
ubuntu-22.04. We fooled around with an organization wide CI variable to configure that, but it broke CI in forks and doesn't really help us much, so it's now undone.The schema repository is a bit of a special snowflake due to Elasticsearch, so we don't exactly use a standard template here, but it's not that dissimilar.
Finally, because this repository has a Dockerfile and we just updated the Docker baseimage to support Node.js 18, there is an empty commit to trigger a new major version release.
Connects pelias/pelias#950
Connects pelias/pelias#951