Fix theme flickering on page load #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update tsconfig.json
penge
force-pushed
the
themes
branch
4 times, most recently
from
0f46641 to
588e273
Compare
- use same :hover for buttons in sidebar and toolbar - merge #toolbar and .bar styles into .bar (related to previous point) - make sure .button content (icon, text) is aligned vertically - fix width of "Auto" button by making sure it has .auto - move #RAW and #RAW-ACTIVE button to the right before #INFO button, making #B button the first one from left - update #RAW and #RAW-ACTIVE - use default pointer for #INFO (it doesn't have action)
- fix .font-area rendering (missing "key") - update dark.css - add fallbacks for --slider-*
penge
force-pushed
the
themes
branch
5 times, most recently
from
2d9d079 to
9f958bd
Compare
- improve how theme is loaded, use localStorage if possible - apply Custom theme to Options page as well - set html[data-page] to allow page-specific customization - use template.html to create notes.html and options.html - update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes theme flickering for themes with other than white background (applies to any larger elements with other than white background).
The problem could be seen on page load, and most noticable on repeated page refresh. It was caused by loading the theme after the page was loaded, and as a result of that, the transition from page's blank background (usually white) to theme's background, was seen as flickering.
The solution was to load the theme as soon as possible and before the page parsing has completed. As theme does not change often, the loading could be even more optimized by using the localStorage.
Other changes:
html[data-page](can be "notes" or "options") to allow page specific customizationbuild.tsand other)