Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactor layering #136

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP: Refactor layering #136

wants to merge 3 commits into from

Conversation

viktordick
Copy link
Collaborator

No description provided.

@viktordick viktordick marked this pull request as draft December 29, 2024 13:34
@viktordick
Copy link
Collaborator Author

@jan-jockusch I started some conceptualization with the plan discussed via mail last week.

Note that this explicitly does not try to be backwards compatible to a layering setup as given currently. I think it will be much simpler to no longer support truly frozen layers where changes are somehow again stored into the custom layer even though the object was originally defined in a lower layer. Instead, every layer must have both a source (provided by the Debian package) and a workdir (where the contents of the Debian package are copied to and where subsequent changes can be pre-applied). A migration path for both systems that currently don't use any layers and also systems that use the current layer setup will need to be provided.

@viktordick viktordick changed the title Refactor layering WIP: Refactor layering Dec 29, 2024
@jan-jockusch
Copy link
Member

@jan-jockusch I started some conceptualization with the plan discussed via mail last week.

Note that this explicitly does not try to be backwards compatible to a layering setup as given currently. I think it will be much simpler to no longer support truly frozen layers where changes are somehow again stored into the custom layer even though the object was originally defined in a lower layer. Instead, every layer must have both a source (provided by the Debian package) and a workdir (where the contents of the Debian package are copied to and where subsequent changes can be pre-applied). A migration path for both systems that currently don't use any layers and also systems that use the current layer setup will need to be provided.

This makes total sense to me. My first attempt at specifying was done only from a user perspective without really reflecting on how this would be implemented. Using source and workdir sounds consistent and clean.

Besides, we have only a very limited number of systems actively using layers in the field, so I hope there'll be no big problem migrating those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants