New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix[dev-cli]: root_dir: use absolute path instead of relative path #1118

Merged

PeterFarber merged 1 commit into permaweb:main from RyanKung:fix_dev_cli_use_absolute_path_in_build_script

Jan 18, 2025

Contributor

RyanKung commented Jan 18, 2025

The output of $(dirname "$0")/.." is a relative path, which may cause an error:

zip I/O error: No such file or directory


          fixed root_dir

5fb9315

Contributor

PeterFarber commented Jan 18, 2025

@RyanKung
Thanks for the PR! I agree that absolute paths can remove ambiguity and are more robust!

PeterFarber merged commit 003e975 into permaweb:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet