Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]Modifing Documents for OpenID Connect Auth Plugin #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP]Modifing Documents for OpenID Connect Auth Plugin #129

wants to merge 2 commits into from

Conversation

yoh1496
Copy link
Contributor

@yoh1496 yoh1496 commented Oct 13, 2021

I modified documents for OIDC AuthPlugin.

Could you review this?

Points modified

  • Documents for unit config

    • Separating io.personium.core config and io.personium.plugin
    • Adding rows about OpenID Connect auth plugin.

  • Documents for developing AuthPlugin

    • Modifing structure of chapters
    • Modifing mismatch between pictures and explanations.
    • Adding about packaging (lacking before)
    • Adding about AuthPluginLoader

Thanks.

@yoh1496 yoh1496 requested a review from tochi-y October 13, 2021 06:28
@yoh1496
Copy link
Contributor Author

yoh1496 commented Oct 13, 2021

Firstly, I modified documents in Japanese. Could you review this? @tochi-y

@tochi-y tochi-y self-assigned this Oct 14, 2021
@tochi-y tochi-y added the enhancement New feature or request label Oct 14, 2021
@shimono shimono requested review from shimono and removed request for tochi-y August 4, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimono shimono Awaiting requested review from shimono

At least 1 approving review is required to merge this pull request.

Assignees

@shimono shimono

@tochi-y tochi-y

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoh1496 @shimono @tochi-y