Skip to content

Commit

Permalink
Remove any final attribute from classes to make more extensible (#4)
Browse files Browse the repository at this point in the history
  • Loading branch information
bencarrr authored Oct 30, 2024
1 parent 5bbe8f3 commit c368f32
Show file tree
Hide file tree
Showing 15 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion src/Values/Category.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class Category extends Serializable
{
final public function __construct(public readonly string $text, public readonly ?Category $subCategory = null)
public function __construct(public readonly string $text, public readonly ?Category $subCategory = null)
{
}

Expand Down
2 changes: 1 addition & 1 deletion src/Values/CategoryCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class CategoryCollection extends Collection
/**
* @param array<TModel> $items
*/
final public function __construct(array $items = [])
public function __construct(array $items = [])
{
parent::__construct($items);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Values/Channel.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

class Channel extends Serializable
{
final public function __construct(
public function __construct(
public readonly string $url,
public readonly string $title,
public readonly string $description,
Expand Down
2 changes: 1 addition & 1 deletion src/Values/ChannelMetadata.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

class ChannelMetadata extends Serializable
{
final public function __construct(
public function __construct(
public readonly bool $locked,
public readonly ?string $guid,
public readonly ?string $author,
Expand Down
2 changes: 1 addition & 1 deletion src/Values/Enclosure.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class Enclosure extends Serializable
{
final public function __construct(
public function __construct(
public readonly string $url,
public readonly string $type,
public readonly int $length
Expand Down
2 changes: 1 addition & 1 deletion src/Values/Episode.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class Episode extends Serializable
{
final public function __construct(
public function __construct(
public readonly string $title,
public readonly EpisodeGuid $guid,
public readonly Enclosure $enclosure,
Expand Down
2 changes: 1 addition & 1 deletion src/Values/EpisodeCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/
class EpisodeCollection extends LazyCollection
{
final public function __construct($source = null)
public function __construct($source = null)
{
parent::__construct($source);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Values/EpisodeGuid.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class EpisodeGuid extends Serializable
{
final public function __construct(public readonly string $value, public readonly bool $isPermaLink)
public function __construct(public readonly string $value, public readonly bool $isPermaLink)
{
}

Expand Down
2 changes: 1 addition & 1 deletion src/Values/EpisodeMetadata.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

class EpisodeMetadata extends Serializable
{
final public function __construct(
public function __construct(
public readonly ?string $link,
public readonly ?DateTime $pubDate,
public readonly ?string $description,
Expand Down
2 changes: 1 addition & 1 deletion src/Values/Funding.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class Funding extends Serializable
{
final public function __construct(public readonly string $url, public readonly string $text)
public function __construct(public readonly string $url, public readonly string $text)
{
}

Expand Down
2 changes: 1 addition & 1 deletion src/Values/FundingCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class FundingCollection extends Collection
/**
* @param array<TModel> $items
*/
final public function __construct(array $items = [])
public function __construct(array $items = [])
{
parent::__construct($items);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Values/Transcript.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class Transcript extends Serializable
{
final public function __construct(
public function __construct(
public readonly string $url,
public readonly string $type,
public readonly ?string $language,
Expand Down
2 changes: 1 addition & 1 deletion src/Values/TranscriptCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class TranscriptCollection extends Collection
/**
* @param array<TModel> $items
*/
final public function __construct(array $items = [])
public function __construct(array $items = [])
{
parent::__construct($items);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Values/Txt.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class Txt extends Serializable
{
final public function __construct(public readonly string $content, public readonly ?string $purpose)
public function __construct(public readonly string $content, public readonly ?string $purpose)
{
}

Expand Down
2 changes: 1 addition & 1 deletion src/Values/TxtCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class TxtCollection extends Collection
/**
* @param array<TModel> $items
*/
final public function __construct(array $items = [])
public function __construct(array $items = [])
{
parent::__construct($items);
}
Expand Down

0 comments on commit c368f32

Please sign in to comment.