Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit DB Tables #535

Draft
wants to merge 19 commits into
base: dev
Choose a base branch
from
Draft

Audit DB Tables #535

wants to merge 19 commits into from

Conversation

Jeff-Thompson12
Copy link
Collaborator

Addresses #361

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #535 (f5ebc78) into dev (6fdbdf9) will decrease coverage by 0.01%.
The diff coverage is 76.92%.

❗ Current head f5ebc78 differs from pull request most recent head 77d886f. Consider uploading reports for the commit 77d886f to get more accurate results

@@            Coverage Diff             @@
##              dev     #535      +/-   ##
==========================================
- Coverage   81.14%   81.13%   -0.01%     
==========================================
  Files          28       28              
  Lines        3224     3233       +9     
==========================================
+ Hits         2616     2623       +7     
- Misses        608      610       +2     
Impacted Files Coverage Δ
R/mod_decision_automation_utils.R 43.18% <0.00%> (-2.06%) ⬇️
R/mod_decision_automation.R 73.76% <66.66%> (+0.06%) ⬆️
R/app_server.R 81.75% <100.00%> (+0.27%) ⬆️
R/utils_startup.R 64.36% <100.00%> (+0.83%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jeff-Thompson12
Copy link
Collaborator Author

Jeff-Thompson12 commented Jul 14, 2023

@pharmaR/riskassessment I would appreciate any insight on what is going on with the R CMD check for this branch. The tests pass locally running devtools::test() but fail when running devtools::check(). It always fails at the same spot (after submitting the decision rules). The changed lines corresponding to the failure are also not very informative. They appear to only affect the timing of the process, but increasing the timeout does not seem to work. Plus the R CMD check seems off for it just being a waiting issue (i.e. "callr subprocess failed: could not start R, exited with non-zero status, has crashed or was killed").

Note the following that I have tried:

  • Rewriting the dbUpdate() into a for loop
  • Using a version of the test database that does not include the audit log triggers
  • Adjusting the app$wait_for_idle() to app$wait_for_value() with extended timeout
  • Also note the checks pass with using a database including the audit log triggers and reverting the changed lines back to what is currently on the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant