Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rk 598 dep rules config #720

Draft
wants to merge 17 commits into
base: dev
Choose a base branch
from
Draft

Rk 598 dep rules config #720

wants to merge 17 commits into from

Conversation

Robert-Krajcik
Copy link
Contributor

Add dependency rules to the config file
closes issue #598

@Robert-Krajcik Robert-Krajcik self-assigned this Dec 6, 2023
@Robert-Krajcik Robert-Krajcik marked this pull request as ready for review December 6, 2023 13:48
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (4cfdbfb) 79.27% compared to head (7639d29) 78.46%.

Files Patch % Lines
R/mod_uploadPackage.R 19.11% 55 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #720      +/-   ##
==========================================
- Coverage   79.27%   78.46%   -0.81%     
==========================================
  Files          33       33              
  Lines        5022     5090      +68     
==========================================
+ Hits         3981     3994      +13     
- Misses       1041     1096      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AARON-CLARK AARON-CLARK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Robert-Krajcik, this is a nice start, but you'll also have to plug in those new configurations to something on the backend for the changes to take effect. @Jeff-Thompson12 is the expert on this stuff, but start off by doing a search for get_db_config() to learn how you can extract the values from the config file and use them in the app's code. So, in the example below, you'll have to run get_db_config('dependencies') to get a list (or a nested list?) of the sub-values you've established here.

Also, you may want to start off by adding the functionality that actually performs the auto assessment of dependencies. This would include adding a checkbox on the upload pkgs tab.

@AARON-CLARK AARON-CLARK marked this pull request as draft December 12, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants