Make source file optional in Statistics class #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjalander
approved these changes
Jan 9, 2025
phate
commented
Jan 9, 2025
| @@ -71,7 +71,7 @@ Statistics::Serialize(char fieldSeparator, char nameValueSeparator) const | |||
| std::ostringstream ss; | |||
|
|
|||
| ss << GetName() << fieldSeparator; | |||
| ss << GetSourceFile().to_str(); | |||
| ss << (GetSourceFile().has_value() ? GetSourceFile().value().to_str() : "None"); | |||
There was a problem hiding this comment.
Commenting myself to block PR. I am not fully convinced that this is a great idea any longer as the filepath itself can be "optional", i.e., just empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could be that we want to gather statistics about the modules that were not created from a file. Support this in the statistics class. This in turn will allow to push the optional source file to the rvsdg::RvsdgModule.