Move phi to rvsdg #784
Move phi to rvsdg #784
Conversation
|
I tried to make the naming of context variables consistent with lambda. For the actual fixpoint variables they are akin to theta (without an input as it is infinite recursion without a real "beginning"), I am not really happy about "recref" but it is at least a bit close to what it represents. I dared rename "recursion variables" to "fixpoint variables" as I think that "recursion is on call" while phi represents the conceptual fixpoint graph reached by dissolving and infinitely "unrolling" a phi structure. I can certainly be convinced to keep the name "RecVar" or similar, so feel free to comment if you would rather insist on that. |
caleridas
force-pushed
the
move-phi
branch
2 times, most recently
from
40bcfcc to
fef6967
Compare
| class PhiBuilder; | ||
|
|
||
| /** | ||
| * \brief Phi node represents the fixpoint of mutually recursive definitions. |
There was a problem hiding this comment.
I don't understand the typo -- "phi node" is singular, so "represents" sounds correct, no?
There was a problem hiding this comment.
I guess my problem is that it was not a proper sentence. Either "A phi node represents..." or "Phi nodeS represent the fixpoint...."
Rename phi::node to comply with the naming scheme used for other node classes. Move it to rvsdg as it is a general-purpose vehicle to represent the fixpoint of recursive (function) definitions, and there is nothing specific to llvm within it.
|
@caleridas I think you missed some review comments from the first round. |
Rename phi::node to comply with the naming scheme used for other node classes. Move it to rvsdg as it is a general-purpose vehicle to represent the fixpoint of recursive (function) definitions, and there is nothing specific to llvm within it.