Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back to top button & binding example #108

Merged
merged 4 commits into from
Dec 31, 2024
Merged

Conversation

jasalt
Copy link
Contributor

@jasalt jasalt commented Dec 29, 2024

Shown globally and uses theme colors and same border radius value as search-box. Mostly just copy paste from: https://www.w3schools.com/howto/howto_js_scroll_to_top.asp.

Trying to follow theme conventions but didn't think of it too seriously regarding the copy pasted Javascript.

Screenshot_20241229_161200

Regarding final styling, the "Top" text could be a arrow up icon and lighter shade of the theme color might be less annoying. Opinions and further edits are welcome but this should be pretty good to get started with.

Also regarding #99, I thought it's maybe fine to just set this globally instead and not just for API doc page. Maybe change later to be more path specific if it seems annoying.

@jasalt
Copy link
Contributor Author

jasalt commented Dec 30, 2024

Somehow messed up creating a new branch for separate PR so a content addition 7b0d8b5 was included to this open PR by accident.

@jasalt jasalt changed the title Add back to top button Add back to top button & binding example Dec 30, 2024
Copy link
Member

@Chemaclass Chemaclass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks!

@Chemaclass Chemaclass merged commit 98da3c7 into phel-lang:master Dec 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants