Changed: Followed actual implementation. #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you write an automated phel test showing that the code works this way as well, please? |
smeghead
approved these changes
Jul 27, 2024
|
@Chemaclass Sorry! Which repository should I write? Is it ok in phel-lang/phel-lang? |
|
I wrote those tests. |
|
@jenshaase what do you think about this? |
|
@Chemaclass I added my comment in the ticket: phel-lang/phel-lang#725 |
|
Thanks again for this PR. However, the goal should be:
Therefore, I suggest leaving the docs as it is, and focus fixing the "bug" instead (eg phel-lang/phel-lang#726 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corresponds to phel-lang/phel-lang#725