-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: passing down ssl verification as it's available in DDGS class #1604
base: main
Are you sure you want to change the base?
Conversation
phi/tools/duckduckgo.py
Outdated
@@ -33,6 +34,8 @@ def __init__( | |||
if news: | |||
self.register(self.duckduckgo_news) | |||
|
|||
self.verify: bool = verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better param would be verify_ssl
. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Will change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Changed verify to verify_ssl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution to Phidat
Description
Please include:
Fixes # N/A
Type of change
Please check the options that are relevant:
Checklist
Additional Notes
Include any deployment notes, performance implications, or other relevant information: When trying to format, according to the CONTRIBUTING.md, the
ruff
module wasn't installed by default using the create venv script. I can see it's in the dev modules inside the pyproject.toml. Is that expected? Thanks!