Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemini list as tool call param fix phi 2238 #1687

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

ysolanky
Copy link
Contributor

@ysolanky ysolanky commented Jan 2, 2025

Description

This PR adds support for tools with input as a list for Gemini

Type of change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update
  • Infrastructure change

Checklist

  • My code follows Phidata's style guidelines and best practices
  • I have performed a self-review of my code
  • I have added docstrings and comments for complex logic
  • My changes generate no new warnings or errors
  • I have added cookbook examples for my new addition (if needed)
  • I have updated requirements.txt/pyproject.toml (if needed)
  • I have verified my changes in a clean environment

Copy link
Contributor

@dirkbrnd dirkbrnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add a comment with example?

@ysolanky
Copy link
Contributor Author

ysolanky commented Jan 3, 2025

@dirkbrnd this change was made just to handle the edge case when the tool param is a list. For example, our ArxivTools toolkit was breaking with Gemini prior to this.

@dirkbrnd
Copy link
Contributor

dirkbrnd commented Jan 3, 2025

Happy if you merge

@ysolanky ysolanky merged commit 35b21fd into main Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants